Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: small doc error #428

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Fix: small doc error #428

merged 1 commit into from
Apr 9, 2021

Conversation

lescactus
Copy link
Contributor

Remove duplicate word in network_peering documentation

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@lescactus
Fix: small doc error
a20c484 
Remove duplicate word in network_peering documentation
@lescactus lescactus requested a review from themantissa as a code owner March 30, 2021 12:39
@themantissa
Copy link
Collaborator

@lescactus thank you for the submission. As soon as we get a chance we'll verify the CLA and review.

@themantissa
Copy link
Collaborator

@lescactus I'd like to approve and merge this but I cannot find your name on the CLA signer list. Did you sign https://www.mongodb.com/legal/contributor-agreement? If so was it using your displayed github name?

@lescactus
Copy link
Contributor Author

@themantissa Can you check again ? I signed with this github username
Thanks

@themantissa
Copy link
Collaborator

Absolutely @lescactus - let me look into what's going on.

@themantissa
Copy link
Collaborator

@lescactus we finally got sorted! Will approve and merge now. Docs changes go out with releases so you'll see it in the next release. Thanks!

themantissa
themantissa approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit b84a663 into mongodb:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lescactus @themantissa